Skip to content

docs: standardize command flag notes - #38199

Closed
iguessitsokay wants to merge 1 commit into
nodejs:masterfrom
iguessitsokay:standardize-flag
Closed

docs: standardize command flag notes#38199
iguessitsokay wants to merge 1 commit into
nodejs:masterfrom
iguessitsokay:standardize-flag

Conversation

@iguessitsokay

Copy link
Copy Markdown
Contributor

remove italic styling from command flag notes

based on the below suggestion:
#38171 (review)

remove italic styling from command flag notes
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. vm Issues and PRs related to the vm subsystem. labels Apr 11, 2021
@RaisinTen

Copy link
Copy Markdown
Member

Thanks for the PR. :)
The subsystem in the commit message should be doc instead of docs but that can be fixed while landing.

@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 11, 2021
@jasnell jasnell added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 12, 2021
@jasnell

jasnell commented Apr 12, 2021

Copy link
Copy Markdown
Member

This really shouldn't have to wait the 48 hours to land. Please 👍🏻 to fast-track.

RaisinTen pushed a commit that referenced this pull request Apr 13, 2021
remove italic styling from command flag notes

PR-URL: #38199
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@RaisinTen

Copy link
Copy Markdown
Member

Landed in f1027ec

@RaisinTen RaisinTen closed this Apr 13, 2021
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
remove italic styling from command flag notes

PR-URL: #38199
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
remove italic styling from command flag notes

PR-URL: #38199
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
danielleadams pushed a commit that referenced this pull request May 8, 2021
remove italic styling from command flag notes

PR-URL: #38199
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants